-
-
Notifications
You must be signed in to change notification settings - Fork 885
Improved 'Making Good PRs' section to improve clarity and maintainability. #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
swastim01
wants to merge
10
commits into
python:main
Choose a base branch
from
swastim01:improve-doc-hierarchy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a99729e
Moved 'Making Good PRs' section up in the hierarchy and clarified its…
swastim01 38a16d6
Reversed the doc hierarchy as it was before
swastim01 0cdb96a
Improved capitalization, added #. instead of hardcoding, trimmed trai…
swastim01 5932e90
Update getting-started/pull-request-lifecycle.rst
swastim01 1c12ebd
Update getting-started/pull-request-lifecycle.rst
swastim01 980bac0
Update getting-started/pull-request-lifecycle.rst
swastim01 bd58b77
Update getting-started/pull-request-lifecycle.rst
swastim01 e43ccdf
Update getting-started/pull-request-lifecycle.rst
swastim01 d36d02e
Update getting-started/pull-request-lifecycle.rst
swastim01 057d5b4
Update getting-started/pull-request-lifecycle.rst
swastim01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update getting-started/pull-request-lifecycle.rst
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
- Loading branch information
commit 1c12ebdc237a92f19033881feb24b767af1839f0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.