Skip to content

Improved 'Making Good PRs' section to improve clarity and maintainability. #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Improved 'Making Good PRs' section to improve clarity and maintainability. #1510

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a99729e
Moved 'Making Good PRs' section up in the hierarchy and clarified its…
swastim01 Feb 9, 2025
38a16d6
Reversed the doc hierarchy as it was before
swastim01 Feb 9, 2025
0cdb96a
Improved capitalization, added #. instead of hardcoding, trimmed trai…
swastim01 Feb 9, 2025
5932e90
Update getting-started/pull-request-lifecycle.rst
swastim01 Feb 12, 2025
1c12ebd
Update getting-started/pull-request-lifecycle.rst
swastim01 Feb 12, 2025
980bac0
Update getting-started/pull-request-lifecycle.rst
swastim01 Feb 12, 2025
bd58b77
Update getting-started/pull-request-lifecycle.rst
swastim01 Feb 12, 2025
e43ccdf
Update getting-started/pull-request-lifecycle.rst
swastim01 Feb 12, 2025
d36d02e
Update getting-started/pull-request-lifecycle.rst
swastim01 Feb 12, 2025
057d5b4
Update getting-started/pull-request-lifecycle.rst
swastim01 Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update getting-started/pull-request-lifecycle.rst 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
  • Loading branch information
@swastim01 @StanFromIreland
swastim01 and StanFromIreland authored Feb 12, 2025
commit d36d02ec2b3c1561e3a475742228e0a3a62b98ba
2 changes: 1 addition & 1 deletion getting-started/pull-request-lifecycle.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ When creating a pull request, following best practices ensures your contribution

``gh-128002: Simplify all_tasks to use PyList_Extend instead of manual iteration``

2. **Write a Meaningful PR Description**
#. **Write a detailed description**

Your PR description should provide **clear context** for reviewers. Answer the following questions:

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy