[suggest] Fix inference of returned collection #7810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this by suppressing the use of Any contexts, which cause arguments to be misinferred. This can cause certain things to be inferred as `<nothing>` instead of `Any`, but that's seems fine.
ilevkivskyi
reviewed
Oct 28, 2019
| # anys than we want for things that consume the inferred | ||
| # types. | ||
| if isinstance(get_proper_type(type_context), AnyType): | ||
| type_context = None |
There was a problem hiding this comment.
This may actually be a big change. I am curious how this behaves w.r.t. to things like
def foo(x: Any) -> None: ...
T = TypeVar('T', bound=int)
def g(x: T) -> T: # also -> Optional[T] and -> List[T], IIRC all three are special cased
...
foo(g('no'))If these example don't change behaviour, then I think this is good to go.
There was a problem hiding this comment.
Doesn't seem to change anything there
JukkaL
added a commit
that referenced
this pull request
Oct 30, 2019
JukkaL
added a commit
that referenced
this pull request
Oct 30, 2019
msullivan
added a commit
that referenced
this pull request
Nov 20, 2019
This is another take at #7810 which was reverted because it caused internal trouble. Do this by ignoring constraints with Any when the Any comes from the suggestion engine. The Any context causes assigned types to be Any overaggressively. Restricting it only to Anys from the suggestion engine avoids the issues seen last time. Doing it at a fine-grained level in constraints allows us to do better refining things like `List[Any]`.
msullivan
added a commit
that referenced
this pull request
Nov 20, 2019
This is another take at #7810 which was reverted because it caused internal trouble. Do this by ignoring constraints with Any when the Any comes from the suggestion engine. The Any context causes assigned types to be Any overaggressively. Restricting it only to Anys from the suggestion engine avoids the issues seen last time. Doing it at a fine-grained level in constraints allows us to do better refining things like `List[Any]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this by suppressing the use of Any contexts, which cause arguments
to be misinferred. This can cause certain things to be inferred as
<nothing>instead ofAny, but that's seems fine.