[suggest] Fix inference from collection literals #7979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another take at #7810 which was reverted because it caused internal trouble. Do this by ignoring constraints with Any when the Any comes from the suggestion engine. The Any context causes assigned types to be Any overaggressively. Restricting it only to Anys from the suggestion engine avoids the issues seen last time. Doing it at a fine-grained level in constraints allows us to do better refining things like `List[Any]`.
JukkaL
approved these changes
Nov 20, 2019
| @@ -426,7 +430,7 @@ def get_suggestion(self, mod: str, node: FuncDef) -> PyAnnotateSignature: | |||
| callsites, | |||
| uses, | |||
| ) | |||
| guesses = self.filter_options(guesses, is_method) | |||
| guesses = self.filter_options(guesses, is_method, ignore_return=True) | |||
There was a problem hiding this comment.
How is the ignore_return=True change related to the rest of the PR?
There was a problem hiding this comment.
I was abusing special_form because has_any_type didn't consider it an any. I didn't want to extend it to know about suggestion_engine also (and doing so would have interfered some with the use of suggestion_engine when refining)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take at #7810 which was reverted because it caused
internal trouble.
Do this by ignoring constraints with Any when the Any comes from the
suggestion engine. The Any context causes assigned types to be Any
overaggressively. Restricting it only to Anys from the suggestion
engine avoids the issues seen last time. Doing it at a fine-grained
level in constraints allows us to do better refining things like
List[Any].