[mypyc] Add BinaryIntOp for low-level integer operations #9108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One improvement here is to support immediate value(without using registers), so |
JukkaL
reviewed
Jul 7, 2020
| RIGHT_SHIFT: '>>', | ||
| } # type: Final | ||
|
|
||
| def __init__(self, type: RType, lhs: Value, rhs: Value, op: int, line: int = -1) -> None: |
There was a problem hiding this comment.
It would be good to store the integer type also here, since different code may be generated for 32 bit and 64 bit adds, for example, on non-C back ends.
There was a problem hiding this comment.
Actually, it's better to do this in a separate PR, and also update things to more generally store the result type.
JukkaL
pushed a commit
that referenced
this pull request
Jul 22, 2020
#9187) Follow-up of #9108 and #9127, generates the new inlined style ops when there is at least one tagged integer present (the previous two PRs actually specialized two ints and two short_ints cases). After this and the remaining merge, we will get rid of `CPyTagged_IsEq`, `CPyTagged_IsNe`, `CPyTagged_IsLt`, `CPyTagged_IsLe`, `CPyTagged_IsGt` and `CPyTagged_IsGe`.
JukkaL
pushed a commit
that referenced
this pull request
Aug 7, 2020
This PR cleans up unused int op definitions including unsafe_short_add and int_compare_op. unsafe_short_add's usages have been replaced with low-level integer op in #9108 and int_compare_op has no usages since all comparison operators are now built in irbuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates mypyc/mypyc#741
This PR introduces
BinaryIntOpto represent all low-level integer binary operations.The block-like logic described in mypyc/mypyc#743 would be handled differently,
BinaryIntOpwould be the building block of it.