Skip to content

[mypyc] Clean up unused int op definitions #9276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2020
Merged

[mypyc] Clean up unused int op definitions #9276

merged 2 commits into from
Aug 7, 2020

Conversation

TH3CHARLie
Copy link
Collaborator

@TH3CHARLie TH3CHARLie commented Aug 7, 2020

This PR cleans up unused int op definitions including unsafe_short_add and int_compare_op.

unsafe_short_add's usages have been replaced with low-level integer op in #9108 and int_compare_op has no usages since all comparison operators are now built in irbuild.

@TH3CHARLie TH3CHARLie changed the title [mypyc] Clean unused int op definitions [mypyc] Clean up unused int op definitions Aug 7, 2020
@TH3CHARLie TH3CHARLie requested a review from JukkaL August 7, 2020 12:44
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see negative lines of code!

@JukkaL JukkaL merged commit e2a7d08 into python:master Aug 7, 2020
@TH3CHARLie TH3CHARLie deleted the clean-unused-int-ops-defs branch August 7, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy