Skip to content

[mypyc] Clean up unused int op definitions #9276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2020
Merged

[mypyc] Clean up unused int op definitions #9276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cee6339
clean unused int op definitions: unsafe_short_add and part of compare_op
TH3CHARLie Aug 7, 2020
4273a11
remove int_compare_opp
TH3CHARLie Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 2 additions & 25 deletions mypyc/primitives/int_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
from typing import Dict, NamedTuple
from mypyc.ir.ops import ERR_NEVER, ERR_MAGIC, BinaryIntOp
from mypyc.ir.rtypes import (
int_rprimitive, bool_rprimitive, float_rprimitive, object_rprimitive, short_int_rprimitive,
int_rprimitive, bool_rprimitive, float_rprimitive, object_rprimitive,
str_rprimitive, RType
)
from mypyc.primitives.registry import (
name_ref_op, binary_op, custom_op, simple_emit, name_emit,
name_ref_op, name_emit,
c_unary_op, CFunctionDescription, c_function_op, c_binary_op, c_custom_op
)

Expand Down Expand Up @@ -81,20 +81,6 @@ def int_binary_op(name: str, c_function_name: str,
error_kind=error_kind)


def int_compare_op(name: str, c_function_name: str) -> None:
int_binary_op(name, c_function_name, bool_rprimitive)
# Generate a straight compare if we know both sides are short
op = name
binary_op(op=op,
arg_types=[short_int_rprimitive, short_int_rprimitive],
result_type=bool_rprimitive,
error_kind=ERR_NEVER,
format_str='{dest} = {args[0]} %s {args[1]} :: short_int' % op,
emit=simple_emit(
'{dest} = (Py_ssize_t){args[0]} %s (Py_ssize_t){args[1]};' % op),
priority=2)


# Binary, unary and augmented assignment operations that operate on CPyTagged ints.

int_binary_op('+', 'CPyTagged_Add')
Expand All @@ -114,15 +100,6 @@ def int_compare_op(name: str, c_function_name: str) -> None:
int_binary_op('//=', 'CPyTagged_FloorDivide', error_kind=ERR_MAGIC)
int_binary_op('%=', 'CPyTagged_Remainder', error_kind=ERR_MAGIC)

# Add short integers and assume that it doesn't overflow or underflow.
# Assume that the operands are not big integers.
unsafe_short_add = custom_op(
arg_types=[int_rprimitive, int_rprimitive],
result_type=short_int_rprimitive,
error_kind=ERR_NEVER,
format_str='{dest} = {args[0]} + {args[1]} :: short_int',
emit=simple_emit('{dest} = {args[0]} + {args[1]};'))


def int_unary_op(name: str, c_function_name: str) -> CFunctionDescription:
return c_unary_op(name=name,
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy