Skip to content

Remove unused local variable, norm_func #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Remove unused local variable, norm_func #140

merged 1 commit into from
Jan 5, 2018

Conversation

jdufresne
Copy link
Member

No description provided.

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about old_value_set = set(s.lower() for s in old_value) instead of map?

@jdufresne
Copy link
Member Author

How about old_value_set = set(s.lower() for s in old_value) instead of map?

That could even use set comprehension:

{s.lower() for s in old_value}

If you'd like, I'll begin working on a PR to convert the uses of map() to use list, dict, or set comprehension instead. I'll do this as separate work though.

@jdufresne
Copy link
Member Author

How about old_value_set = set(s.lower() for s in old_value) instead of map?

Done in #142

@encukou encukou added this to the 3.1 milestone Dec 20, 2017
@encukou encukou merged commit 98c535b into python-ldap:master Jan 5, 2018
@jdufresne jdufresne deleted the unused branch March 30, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy