Update uses of map() to use list/set comprehensions instead #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 69.35% 69.34% -0.01%
==========================================
Files 49 49
Lines 4708 4707 -1
Branches 800 808 +8
==========================================
- Hits 3265 3264 -1
Misses 1088 1088
Partials 355 355
Continue to review full report at Codecov.
|
tiran
reviewed
Dec 19, 2017
| @@ -108,7 +108,7 @@ def decodeControlValue(self,encodedControlValue): | |||
| for deref_res in decodedValue: | |||
| deref_attr,deref_val,deref_vals = deref_res[0],deref_res[1],deref_res[2] | |||
| partial_attrs_dict = { | |||
| str(tv[0]): map(str,tv[1]) | |||
| str(tv[0]): [str(v) for v in tv[1]] | |||
There was a problem hiding this comment.
In Python 2, list comprehensions leak the internal variable. Therefore I prefer list() for list comprehensions.
There was a problem hiding this comment.
I think it's OK to use comprehensions with one-letter variable names.
No need to change this.
encukou
approved these changes
Dec 19, 2017
|
3.0 will need another change, so let's include this one in 3.0 as well. |
Updates style to modern Python idioms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates style to modern Python idioms.