Skip to content

Deprecate cidict's strlist functions #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented May 28, 2020

The functions are undocumented, untested, unused, and can now be trivialy
implemented with set operations.

Signed-off-by: Christian Heimes cheimes@redhat.com

The functions are undocumented, untested, unused, and can now be trivialy
implemented with set operations.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran added this to the 3.3 milestone May 28, 2020
@tiran tiran requested a review from encukou May 28, 2020 07:55
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #336 into master will decrease coverage by 3.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   73.03%   69.93%   -3.11%     
==========================================
  Files          39       39              
  Lines        3175     3176       +1     
  Branches      484      484              
==========================================
- Hits         2319     2221      -98     
- Misses        726      806      +80     
- Partials      130      149      +19     
Impacted Files Coverage Δ
Lib/ldap/cidict.py 100.00% <100.00%> (+30.76%) ⬆️
Lib/ldap/compat.py 18.86% <0.00%> (-47.17%) ⬇️
Lib/ldap/ldapobject.py 66.66% <0.00%> (-11.25%) ⬇️
Lib/ldap/sasl.py 77.77% <0.00%> (-8.34%) ⬇️
Lib/slapdtest/_slapdtest.py 77.25% <0.00%> (-7.75%) ⬇️
Lib/ldap/__init__.py 82.69% <0.00%> (-7.70%) ⬇️
Lib/ldap/functions.py 90.00% <0.00%> (-7.50%) ⬇️
Lib/ldap/dn.py 94.23% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e084ae...5ac0c28. Read the comment docs.

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukou encukou merged commit 269df17 into python-ldap:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy