Improve Internal Logic for Network Retries #4880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poolitzer
approved these changes
Jul 27, 2025
harshil21
reviewed
Jul 28, 2025
There was a problem hiding this comment.
I see what you meant now. However it still doesn't fix the core of the issue? If you have infinite_loop=True, and max_retries > 0, we're still incrementing retries even for successful calls.
That particular parameter combination does not happen in our library, but the function should still have correct behavior for all combinations of inputs imo.
harshil21
reviewed
Jul 28, 2025
Except for coverage reasons, I don't see a need. this PR doesn't introduce any new functionality that would need testing. test for the existing network retry use cases are already in place :) |
|
welp, that took a bit of a detour, but ready for re-review now :) |
harshil21
reviewed
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My take on closing #4871 :) Maybe the diff explains my intentions better than my words :D