Skip to content

[BE] fix flake8 rule F824: global name / nonlocal name is unused #159042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[BE] fix flake8 rule F824: global name / nonlocal name is unused #159042

wants to merge 2 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jul 24, 2025 •
edited
Loading

Note: You only need to add global / nonlocal if you assign the variable in the local scope, i.e., change the variable id(x). If you are modifying the variable's state via methods rather than assignments, you do not need global / nonlocal statements for that variable.

For example:

my_list = [1, 2, 3]


def func1():
    my_list.clear()  # this does not change `id(my_list)`


def func2():
    my_list[:] = []  # this does not change `id(my_list)`


def func3():
    global my_list
    my_list = []  # this changes `id(my_list)`

Stack from ghstack (oldest at bottom):

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @ezyang @SherlockNoMad @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela

@XuehaiPan
Update
b08ca55 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159042

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (9 Unrelated Failures)

As of commit 4d0dbd4 with merge base ee97dbf (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fx labels Jul 24, 2025
This was referenced Jul 24, 2025
Closed
Closed
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 24, 2025
@XuehaiPan
[BE] fix flake8 rule F824: global name / nonlocal name is unused
460cdb6 
ghstack-source-id: 52e061d
Pull-Request: pytorch#159042
@XuehaiPan XuehaiPan added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Jul 24, 2025
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 24, 2025
@XuehaiPan
[BE] fix flake8 rule F824: global name / nonlocal name is unused
22ba4e3 
ghstack-source-id: 52e061d
Pull-Request: pytorch#159042
@XuehaiPan XuehaiPan added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 24, 2025
@XuehaiPan
Update
4d0dbd4 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 24, 2025
@XuehaiPan
[BE] fix flake8 rule F824: global name / nonlocal name is unused
1048765 
ghstack-source-id: 8d442ad
Pull-Request: pytorch#159042
@XuehaiPan XuehaiPan closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

@EikanWang EikanWang Awaiting requested review from EikanWang EikanWang is a code owner

@gujinghui gujinghui Awaiting requested review from gujinghui gujinghui is a code owner

@divyanshk divyanshk Awaiting requested review from divyanshk divyanshk is a code owner

@ramanishsingh ramanishsingh Awaiting requested review from ramanishsingh ramanishsingh is a code owner

@bdhirsh bdhirsh Awaiting requested review from bdhirsh bdhirsh is a code owner

@lezcano lezcano Awaiting requested review from lezcano lezcano is a code owner

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1 shubhambhokare1 is a code owner

@justinchuby justinchuby Awaiting requested review from justinchuby justinchuby is a code owner

@wschin wschin Awaiting requested review from wschin wschin is a code owner

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@soulitzer soulitzer Awaiting requested review from soulitzer soulitzer is a code owner

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: distributed (checkpoint) release notes: distributed (fsdp) release notes category release notes: inductor (aoti) release notes: quantization release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuehaiPan @facebook-github-bot @pytorchbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy