Skip to content

[BE] fix remaining flake8 v7 warnings #159044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[BE] fix remaining flake8 v7 warnings #159044

wants to merge 3 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jul 24, 2025 •
edited
Loading

@XuehaiPan
Update
647d9a1 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159044

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (9 Unrelated Failures)

As of commit 67df290 with merge base ee97dbf (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: onnx torch.onnx related changes that should show up in the release notes release notes: quantization release notes category release notes: distributed (checkpoint) labels Jul 24, 2025
This was referenced Jul 24, 2025
Closed
Closed
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 24, 2025
@XuehaiPan
[BE] fix remaining flake8 v7 warnings
1936a7a 
ghstack-source-id: 6b281f6
Pull-Request: pytorch#159044
@XuehaiPan XuehaiPan added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Jul 24, 2025
@XuehaiPan
Update
441bf68 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 24, 2025
@XuehaiPan
[BE] fix remaining flake8 v7 warnings
8584911 
ghstack-source-id: 15fb874
Pull-Request: pytorch#159044
XuehaiPan
XuehaiPan commented Jul 24, 2025
View reviewed changes
@XuehaiPan XuehaiPan added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 24, 2025
@XuehaiPan
Update
67df290 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 24, 2025
@XuehaiPan
[BE] fix remaining flake8 v7 warnings
bb9ed47 
ghstack-source-id: fd81a93
Pull-Request: pytorch#159044
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@rec rec mentioned this pull request Jul 24, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rec added a commit that referenced this pull request Jul 28, 2025
@rec
[inductor] Remove unnecessary noqas of set_linter (see #159044)
e6f76e1 
ghstack-source-id: 20136d3
Pull Request resolved: #159252
rec added a commit that referenced this pull request Jul 28, 2025
@rec
[inductor] Remove unnecessary noqas of set_linter (see #159044)
db1910e 
ghstack-source-id: 2c3b6b3
Pull Request resolved: #159252
rec added a commit that referenced this pull request Jul 28, 2025
@rec
[inductor] Remove unnecessary noqas of set_linter (see #159044)
f383cab 
ghstack-source-id: 4c3ea5d
Pull Request resolved: #159252
rec added a commit that referenced this pull request Jul 28, 2025
@rec
[inductor] Remove unnecessary noqas of set_linter (see #159044)
96859a5 
ghstack-source-id: 23a8e95
Pull Request resolved: #159252
rec added a commit to rec/pytorch that referenced this pull request Jul 29, 2025
@rec
[inductor] Remove unnecessary noqas of set_linter (see pytorch#159044)
1bf727c 
ghstack-source-id: 23a8e95
Pull Request resolved: pytorch#159252
yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@XuehaiPan @yangw-dev
[BE] fix remaining flake8 v7 warnings (#159044)
940caec 
Pull Request resolved: #159044
Approved by: https://github.com/Skylion007
ghstack dependencies: #159043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rec rec rec left review comments

@Skylion007 Skylion007 Skylion007 approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lezcano lezcano Awaiting requested review from lezcano lezcano is a code owner

@nikitaved nikitaved Awaiting requested review from nikitaved nikitaved is a code owner

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk IvanYashchuk is a code owner

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1 shubhambhokare1 is a code owner

@justinchuby justinchuby Awaiting requested review from justinchuby justinchuby is a code owner

@wschin wschin Awaiting requested review from wschin wschin is a code owner

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

@albanD albanD Awaiting requested review from albanD albanD is a code owner

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx Merged module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (checkpoint) release notes: onnx torch.onnx related changes that should show up in the release notes release notes: quantization release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XuehaiPan @pytorchmergebot @rec @Skylion007 @facebook-github-bot @pytorchbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy