Skip to content

Improve test suite to exclude TLS 1.3 tests on PHP 7.3 #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

clue
Copy link
Member

@clue clue commented Nov 17, 2019

Explicit TLS 1.3 support will be available in PHP 7.4: php/php-src#3909

Older PHP versions implicitly support TLS 1.3 provided that the
underlying OpenSSL version supports TLS 1.3. However, for PHP 7.3 some
(not so) recent changes implicitly disable TLS 1.3, so we skip TLS 1.3 tests on
affected PHP versions: php/php-src#3317

Builds on top of #186, #201 and #202
Noticed this due to a build error while working on reactphp/reactphp#432

@clue clue added this to the v1.4.0 milestone Nov 17, 2019
@clue clue force-pushed the php7.3-excludes-tls1.3 branch from 59e524b to bca0f77 Compare November 17, 2019 19:44
Explicit TLS 1.3 support will be available in PHP 7.4:
php/php-src#3909

Older PHP versions implicitly support TLS 1.3 provided that the
underlying OpenSSL version supports TLS 1.3. However, for PHP 7.3 some
recent changes implicitly disable TLS 1.3, so we skip TLS 1.3 tests on
affected PHP versions: php/php-src#3317
@clue clue force-pushed the php7.3-excludes-tls1.3 branch from bca0f77 to 198690e Compare November 17, 2019 19:44
@clue clue requested review from jsor and WyriHaximus November 17, 2019 20:09
@jsor jsor merged commit 420e02b into reactphp:master Nov 17, 2019
@clue clue deleted the php7.3-excludes-tls1.3 branch November 18, 2019 09:01
@clue clue mentioned this pull request Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy