Skip to content

Support Humble #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Support Humble #42

merged 5 commits into from
Jan 25, 2023

Conversation

shu-13
Copy link

@shu-13 shu-13 commented Jan 19, 2023

What does this implement/fix?

Humbleで動作確認ができたので、READMEのリンクなどを更新

Does this close any currently open issues?

No

How has this been tested?

実機を用いて動作確認を行った
ラズパイマウスにRaspi4を搭載し、Ubuntu 20.04でDockerを立ち上げた。
Dockerはversion 20.10.22、使用したImageはros:humble-ros-base
9軸IMUをラズパイマウス に接続し、以下のコマンドを実行した。

# 権限を変更
$ sudo chmod 666 /dev/ttyACM0
# Terminal 1
$ ros2 run rt_usb_9axisimu_driver rt_usb_9axisimu_driver
# Terminal 2
$ ros2 lifecycle set rt_usb_9axisimu_driver configure
$ ros2 lifecycle set rt_usb_9axisimu_driver activate
# Echo topics (Press Ctrl+C for exit)
$ ros2 topic echo /imu/data_raw
$ ros2 topic echo /imu/mag
$ ros2 topic echo /imu/temperature

上記topic echoで各種値が返ってくることを確認した

Any other comments?

Checklists

@shu-13 shu-13 requested a review from ShotaAk January 19, 2023 04:36
@ShotaAk
Copy link
Contributor

ShotaAk commented Jan 20, 2023

KineticとDashingはサポートが切れたので削除をお願いします。
(ステータスバッジも見れないので)

また、Noeticには対応しているので、行の追加をお願いします。

image

image

Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントの確認お願いします。

また、PRのdescriptionに、動作テストに使用した環境(dockerイメージなど)と、動作テストに使用したコマンド、何を確認したのか、追記をお願いします。

README.md Outdated
@@ -71,14 +73,16 @@ ROS Melodic等ROS 1のパッケージについては[`master`](https://github.co
$ sudo apt install ros-dashing-rt-usb-9axisimu-driver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dashingはサポートが切れたので削除お願いします。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応しました

@ShotaAk
Copy link
Contributor

ShotaAk commented Jan 25, 2023

Noetic対応の文言も追加お願いします。

image

@ShotaAk
Copy link
Contributor

ShotaAk commented Jan 25, 2023

LGTM

@ShotaAk ShotaAk merged commit 1bced85 into ros2-devel Jan 25, 2023
@ShotaAk ShotaAk deleted the feature/support-humble branch January 25, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy