-
-
Notifications
You must be signed in to change notification settings - Fork 637
large cleanup of master reference file #40411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
@@ -152,7 +152,7 @@ REFERENCES: | |||
.. [AGHJLPR2017] Benjamin Assarf, Ewgenij Gawrilow, Katrin Herr, Michael Joswig, | |||
Benjamin Lorenz, Andreas Paffenholz, and Thomas Rehn, | |||
*Computing convex hulls and counting integer points with | |||
polymake*, Math. Program. Comput. 9 (2017), no. 1, 1–38, | |||
polymake*, Math. Program. Comput. 9 (2017), no. 1, 1-38, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here and elsewhere, are you replacing that kind of -
symbol with the "correct" one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(more precisely, "en dash" with "hyphen" (the latter the usual ASCII -
) - right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whether I do the right thing. I am replacing some unicode character by just the ascii minus sign. Is this right ?
looks good. |
oops, sorry, I missed that you had given a positive review already, and so added a doi as you wanted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ideally, of course, we should switch to bibfiles (sphinx supports them well). But the amount of data to convert is substantial, and can be helped if all the DOIs available are added. |
it seems that pdf doc does not build [sagemath_doc_pdf-none] [spkg-install] [reference] /sage/src/doc/en/reference/references/index.rst:247: WARNING: Inline emphasis start-string without end-string. [docutils] |
5688445
to
f62cfff
Compare
as I have found the issue, I will allow myself to set back to positive |
sagemathgh-40411: large cleanup of master reference file somewhat large (sorry), but only simple changes - about using stars around the title of articles - removing one duplicate - adding some doi links ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40411 Reported by: Frédéric Chapoton Reviewer(s): Dima Pasechnik, Frédéric Chapoton
sagemathgh-40411: large cleanup of master reference file somewhat large (sorry), but only simple changes - about using stars around the title of articles - removing one duplicate - adding some doi links ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40411 Reported by: Frédéric Chapoton Reviewer(s): Dima Pasechnik, Frédéric Chapoton
somewhat large (sorry), but only simple changes
📝 Checklist