Remove precisely the prefix instead of strip #40415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Looks like a good idea. Let's wait for the CI. |
|
Maybe we want to enable this rule in the CI as well. (Though not in scope here.) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am a first time contributor, still navigating the
sagehuge codebase. Please let me know if I am not aware of something.This PR resolves a few occurrences of the error B005 from
ruff.It looks pretty clear to me that that intent of the code is to remove precisely these prefixes rather than, for example, removing all the leading occurrences of the letters d, e, f, a, u, l, t. I think the example in the docs of
ruffillustrates quite well the difference.Tested with
ruff check src/sage --select B005📝 Checklist
⌛ Dependencies