Skip to content

Remove unnecessary empty string in print function #40419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Remove unnecessary empty string in print function #40419

wants to merge 4 commits into from
+10 −10

Conversation

tqa236
Copy link

@tqa236 tqa236 commented Jul 16, 2025 •
edited
Loading

depends on #40415

Autofix a few FURB105 errors with ruff check src/sage --select FURB105 --fix in the first commit and enforce the rule in the second commit to avoid regression. Let me know if updating pyproject.toml with enforceable rules are ok or not. I can revert the second commit if needed.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@fchapoton
Copy link
Contributor

pyproject.toml is probably not the right place ; see .github/workflows/lint.yml

@tqa236
Copy link
Author

tqa236 commented Jul 16, 2025

thanks a lot for pointing me to that file @fchapoton. I found that the command line is more natural for opt-out rather than opt-in, but I moved it there anyway.

Abusing a bit the scope of this PR, I added the rule B005 here too, as requested by @user202729, if the config works correctly, this PR should fail now but pass after #40415 is merged.

@tqa236
Copy link
Author

tqa236 commented Jul 16, 2025 •
edited
Loading

Look like the B005 violations are correctly flagged here. Regarding the 2 FURB105 violations, it's ok to fix errors in src/sage_setup/autogen and build/sage_bootstrap? I just assumed autogen is short for autogenerated code (?) and left it out.

@fchapoton
Copy link
Contributor

fchapoton commented Jul 16, 2025 •
edited
Loading

you can also fix the failure in autogen, as this is not an autogenerated file

and also in bootstrap, for sure

@tqa236
Copy link
Author

tqa236 commented Jul 16, 2025

i pushed the fix but it's a bit strange that this check failed. Anything we can do with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s: needs review t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tqa236 @fchapoton
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy