Fixed the DockerRuntime to apply the provided HostConfig, thereby supporting volume mount functionality
#522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig`, thereby supporting volume mount functionality fix(Docker): Fixed the `DockerContainerPlatform` to properly initialize containers binds, thereby supporting volume mount functionality fix(DockerCompose): Fixed the docker-compose deployment by replacing `Garnet` by `Redis` Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Docker runtime functionality to properly support volume mounting and updates deployment configuration to use Redis instead of Garnet. The changes also include spelling corrections for "preferred" vs "prefered" throughout the dashboard components.
- Enables volume mount functionality by properly applying provided HostConfig in DockerRuntime
- Fixes container volume binding syntax in DockerContainerPlatform
- Replaces Garnet with Redis in docker-compose deployment configuration
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/runtime/Synapse.Runtime.Docker/Services/DockerRuntime.cs | Updated to use provided HostConfig and insert mounts at specific positions |
| src/dashboard/Synapse.Dashboard/wwwroot/index.html | Fixed spelling from "prefered" to "preferred" |
| src/dashboard/Synapse.Dashboard/Services/JsInterop.cs | Fixed spelling from "prefered" to "preferred" |
| src/dashboard/Synapse.Dashboard/Layout/MainLayout.razor | Fixed spelling from "prefered" to "preferred" |
| src/core/Synapse.Core/Resources/DockerRuntimeConfiguration.cs | Added HostConfig property and updated property ordering |
| src/core/Synapse.Core.Infrastructure.Containers.Docker/DockerContainerPlatform.cs | Fixed volume binding syntax from "=" to ":" |
| deployments/docker-compose/docker-compose.yml | Replaced Garnet with Redis service |
| deployments/docker-compose/.env | Updated connection string from Garnet to Redis |
src/core/Synapse.Core.Infrastructure.Containers.Docker/DockerContainerPlatform.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
DockerRuntimeto apply the providedHostConfig, thereby supporting volume mount functionalityDockerContainerPlatformto properly initialize containers binds, thereby supporting volume mount functionalityGarnetbyRedisFixes #521