Fixed the WorkflowInstanceController not to claim instances of workflows explicitly assigned to other operators
#526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stances of workflows explicitly assigned to other operators Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
… workflow instance is claimable Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the WorkflowInstanceController to prevent it from claiming workflow instances that are explicitly assigned to other operators. The fix introduces logic to check workflow-level operator assignments in addition to instance-level assignments.
Key changes:
- Adds new interface
IWorkflowControllerto expose monitored workflows - Implements operator assignment checking logic that considers both workflow instance and workflow level labels
- Refactors claim/release logic to use centralized claimability checking
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| WorkflowInstanceController.cs | Adds workflow controller dependency and implements claimability checking logic |
| WorkflowController.cs | Implements IWorkflowController interface to expose workflows collection |
| IWorkflowController.cs | New interface defining access to monitored workflows |
| IOperatorController.cs | Minor documentation update for consistency |
| Program.cs | Registers IWorkflowController service binding |
src/operator/Synapse.Operator/Services/Interfaces/IWorkflowController.cs
Show resolved
Hide resolved
src/operator/Synapse.Operator/Services/Interfaces/IWorkflowController.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
WorkflowInstanceControllernot to claim instances of workflows explicitly assigned to other operatorsFixes #525