Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Fix ROUND function for 2 args. #580

Merged
merged 2 commits into from
Dec 26, 2018
Merged

Fix ROUND function for 2 args. #580

merged 2 commits into from
Dec 26, 2018

Conversation

kuba--
Copy link
Contributor

@kuba-- kuba-- commented Dec 21, 2018

Signed-off-by: kuba-- kuba@sourced.tech
Fixes src-d/sourced-ce#168
Closes #579

Signed-off-by: kuba-- <kuba@sourced.tech>
@kuba-- kuba-- requested review from smacker and a team December 21, 2018 19:16
@ajnavarro
Copy link
Contributor

ajnavarro commented Dec 24, 2018

Could you add a unit test too, please?

@kuba--
Copy link
Contributor Author

kuba-- commented Dec 24, 2018

I've added integration tests, because children had to be called. All unit tests pass without any problems

Copy link
Contributor

@smacker smacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Signed-off-by: kuba-- <kuba@sourced.tech>
@kuba--
Copy link
Contributor Author

kuba-- commented Dec 24, 2018

@ajnavarro - I've extended current unit tests by adding extra checks for Children()

@ajnavarro ajnavarro merged commit 09a67ca into src-d:master Dec 26, 2018
@kuba-- kuba-- deleted the fix-round branch December 27, 2018 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy