Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Fix ROUND function for 2 args. #580

Merged
merged 2 commits into from
Dec 26, 2018
Merged

Fix ROUND function for 2 args. #580

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3d6053
Fix ROUND function for 2 args.
Dec 21, 2018
8312402
Add unit tests
Dec 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add unit tests 
Signed-off-by: kuba-- <kuba@sourced.tech>
  • Loading branch information
kuba-- committed Dec 24, 2018
commit 831240261a2f78aa654ef7d42f34d67118d3fc40
11 changes: 10 additions & 1 deletion sql/expression/function/ceil_round_floor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ func TestCeil(t *testing.T) {

t.Run(tt.name, func(t *testing.T) {
require := require.New(t)
exprs := f.Children()
require.True(len(exprs) > 0 && len(exprs) < 3)
require.NotNil(exprs[0])

result, err := f.Eval(sql.NewEmptyContext(), tt.row)
if tt.err != nil {
Expand Down Expand Up @@ -88,6 +91,9 @@ func TestFloor(t *testing.T) {

t.Run(tt.name, func(t *testing.T) {
require := require.New(t)
exprs := f.Children()
require.True(len(exprs) > 0 && len(exprs) < 3)
require.NotNil(exprs[0])

result, err := f.Eval(sql.NewEmptyContext(), tt.row)
if tt.err != nil {
Expand Down Expand Up @@ -206,9 +212,12 @@ func TestRound(t *testing.T) {

f, err := NewRound(args...)
req := require.New(t)

req.Nil(err)

exprs := f.Children()
req.True(len(exprs) > 0 && len(exprs) < 3)
req.NotNil(exprs[0])

result, err := f.Eval(sql.NewEmptyContext(), sql.NewRow([]byte{1, 2, 3}, 2))

req.Equal(int32(0), result)
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy