Skip to content

fix: value/checked not correctly set using spread #15239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2025
Merged

fix: value/checked not correctly set using spread #15239

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ca0c71
set value/checked by JS
adiguba Feb 7, 2025
47b9914
test
adiguba Feb 7, 2025
577a863
changeset
adiguba Feb 7, 2025
0531f27
fix test form-default-value-spread
adiguba Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test form-default-value-spread
  • Loading branch information
@adiguba
adiguba committed Feb 7, 2025
commit 0531f279c50306462903379930e14b7ecd66b3c4
15 changes: 7 additions & 8 deletions packages/svelte/src/internal/client/dom/elements/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,19 +382,18 @@ export function set_attributes(
if (name === 'value' || name === 'checked') {
// removing value/checked also removes defaultValue/defaultChecked — preserve
let input = /** @type {HTMLInputElement} */ (element);

const use_default = prev === undefined;
if (name === 'value') {
let prev = input.defaultValue;
let previous = input.defaultValue;
input.removeAttribute(name);
input.defaultValue = prev;
input.value = '';
input.defaultValue = previous;
// @ts-ignore
input.__value = null;
input.value = input.__value = use_default ? previous : null;
} else {
let prev = input.defaultChecked;
let previous = input.defaultChecked;
input.removeAttribute(name);
input.defaultChecked = prev;
input.checked = false;
input.defaultChecked = previous;
input.checked = use_default ? previous : false;
}
} else {
element.removeAttribute(key);
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy