Skip to content

fix: value/checked not correctly set using spread #15239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-zoos-repeat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: value/checked not correctly set using spread
13 changes: 8 additions & 5 deletions packages/svelte/src/internal/client/dom/elements/attributes.js
Original file line number Diff line number Diff line change
Expand Up @@ -382,15 +382,18 @@ export function set_attributes(
if (name === 'value' || name === 'checked') {
// removing value/checked also removes defaultValue/defaultChecked — preserve
let input = /** @type {HTMLInputElement} */ (element);

const use_default = prev === undefined;
if (name === 'value') {
let prev = input.defaultValue;
let previous = input.defaultValue;
input.removeAttribute(name);
input.defaultValue = prev;
input.defaultValue = previous;
// @ts-ignore
input.value = input.__value = use_default ? previous : null;
} else {
let prev = input.defaultChecked;
let previous = input.defaultChecked;
input.removeAttribute(name);
input.defaultChecked = prev;
input.defaultChecked = previous;
input.checked = use_default ? previous : false;
}
} else {
element.removeAttribute(key);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { flushSync } from 'svelte';
import { test } from '../../test';

export default test({
async test({ target, assert }) {
// Test for https://github.com/sveltejs/svelte/issues/15237
const [setValues, clearValue] = target.querySelectorAll('button');
const [text1, text2, check1, check2] = target.querySelectorAll('input');

assert.equal(text1.value, '');
assert.equal(text2.value, '');
assert.equal(check1.checked, false);
assert.equal(check2.checked, false);

flushSync(() => {
setValues.click();
});

assert.equal(text1.value, 'message');
assert.equal(text2.value, 'message');
assert.equal(check1.checked, true);
assert.equal(check2.checked, true);

flushSync(() => {
clearValue.click();
});

assert.equal(text1.value, '');
assert.equal(text2.value, '');
assert.equal(check1.checked, false);
assert.equal(check2.checked, false);
}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<script>
let value = $state();
let checked = $state(false);

function setValues() {
value = 'message';
checked = true;
}
function clearValues() {
value = null;
checked = null;
}
</script>

<button onclick={setValues}>setValues</button>
<button onclick={clearValues}>clearValues</button>

<input type="text" {value} />
<input type="text" {value} {...{}} />

<input type="checkbox" {checked} />
<input type="checkbox" {checked} {...{}} />
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy