fix: unset batch before flushing queued effects #16482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- schedule rerunning effects based on the sources that are dirty, not just rerunning them all blindly (excempting async effects which will have run by that time already)
|
🦋 Changeset detectedLatest commit: 82e431f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…he rest of this cursed function
Rich-Harris
commented
Jul 23, 2025
gyzerok
reviewed
Jul 23, 2025
| @@ -202,9 +203,22 @@ export class Batch { | |||
| this.#effects = []; | |||
| this.#block_effects = []; | |||
|
|
|||
| // If sources are written to, then work needs to happen in a separate batch, else prior sources would be mixed with | |||
| // newly updated sources, which could lead to infinite loops when effects run over and over again. | |||
There was a problem hiding this comment.
Since we've been hunting infinite loop problem in our code in 5.35.5 I am wondering if this comment means that there were indeed a possibility that svelte creates them? That'd be a relief to know
There was a problem hiding this comment.
It should only happen in case of async though
There was a problem hiding this comment.
Possibly! Will be interested to see if this version fixes things
|
Did anybody said already that @dummdidumm is the GOAT? 🐐 |
|
multiple times a day 😆 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wish I could claim credit for this but it's all @dummdidumm, I'm just opening a PR to make working on it easier. Essentially, we now create a fresh batch to handle any state changes that occur during effects that run after the prior batch is committed
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint