Skip to content

fix: unset batch before flushing queued effects #16482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 23, 2025
Merged

fix: unset batch before flushing queued effects #16482

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b8893f9
- add state changes resulting from an $effect to a separate new batch
dummdidumm Jul 22, 2025
26f46ba
test
dummdidumm Jul 22, 2025
1ca795b
Merge branch 'main' into async-fixes
dummdidumm Jul 22, 2025
0c0662b
better fix
dummdidumm Jul 22, 2025
4cb4847
tests
dummdidumm Jul 22, 2025
9e54e9a
this fixes the last test somehow
dummdidumm Jul 22, 2025
23b44ce
fix #16477
Rich-Harris Jul 22, 2025
ab740c9
Merge branch 'async-fixes' into async-fixes-2
Rich-Harris Jul 22, 2025
09357ae
typo
Rich-Harris Jul 22, 2025
a77ee84
copy over changeset from #16477
Rich-Harris Jul 22, 2025
72f8bfe
copy over changeset from #16464
Rich-Harris Jul 22, 2025
0ead782
changeset
Rich-Harris Jul 22, 2025
f92dfc1
dedupe
Rich-Harris Jul 22, 2025
a6d4644
move flushing_sync check inside Batch.ensure
Rich-Harris Jul 22, 2025
f686355
unused
Rich-Harris Jul 22, 2025
a98c75e
flushing_sync -> is_flushing_sync
Rich-Harris Jul 22, 2025
457b849
remove flush_effects method
Rich-Harris Jul 22, 2025
f1f34f7
dedupe declaration
Rich-Harris Jul 23, 2025
10b2d64
tweak
Rich-Harris Jul 23, 2025
6c2f0f9
tweak
Rich-Harris Jul 23, 2025
82e431f
update comment — it _does_ feel slightly wrong, but no wronger than t…
Rich-Harris Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changeset
  • Loading branch information
@Rich-Harris
Rich-Harris committed Jul 22, 2025
commit 0ead78284bc39ea6625249b8323c2086dcfa59e2
5 changes: 5 additions & 0 deletions .changeset/shiny-walls-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: prevent infinite async loop
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy