Skip to content

fix: avoid activating search box when cmd + shift + k is pressed #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025

Conversation

neorth
Copy link
Contributor

@neorth neorth commented Jun 13, 2025

When using Ctrl/Cmd+Shift+k in repl/tutorial you expect the current line to be removed, instead search in the nav-bar is focused. This change should fix that.

When using Ctrl/Cmd+Shift+k in repl/tutorial you expect the current line to be removed, instead search in the nav-bar is focused. This change should fix that.
Copy link

vercel bot commented Jun 13, 2025

@neorth is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@neorth neorth changed the title Only focus search when no shiftKey fix: Only focus search when no shiftKey Jun 13, 2025
Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
svelte-dev ✅ Ready (Inspect) Visit Preview Jul 31, 2025 7:42am

@eltigerchino eltigerchino changed the title fix: Only focus search when no shiftKey fix: avoid activating search box when cmd + shift + k is pressed Jul 31, 2025
Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tested and this fixes the issue on macOS.

@eltigerchino eltigerchino merged commit d2cba92 into sveltejs:main Jul 31, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy