Skip to content

[Notifier] Notifier add test for adding transport factories to framework extension #40845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2021
Merged

[Notifier] Notifier add test for adding transport factories to framework extension #40845

merged 1 commit into from
Apr 18, 2021

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Apr 17, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Follow up of #40843 and #40844

Needs to be rebased after both were merged.

See changes: ddf61c2

@jschaedl jschaedl changed the title Notifier add test add transport factory to framework extension [FrameworkBundle] Notifier add test add transport factory to framework extension Apr 17, 2021
@jschaedl jschaedl force-pushed the notifier-add-test-add-transport-factory-to-framework-extension branch 2 times, most recently from 948a692 to 97378de Compare April 17, 2021 15:36
@jschaedl jschaedl mentioned this pull request Apr 17, 2021
Merged
3 tasks
@jschaedl jschaedl force-pushed the notifier-add-test-add-transport-factory-to-framework-extension branch from 97378de to c41e164 Compare April 17, 2021 15:46
@jschaedl jschaedl changed the title [FrameworkBundle] Notifier add test add transport factory to framework extension [FrameworkBundle] Notifier add test for adding transport factoris to framework extension Apr 17, 2021
@jschaedl jschaedl changed the title [FrameworkBundle] Notifier add test for adding transport factoris to framework extension [FrameworkBundle] Notifier add test for adding transport factories to framework extension Apr 17, 2021
@jschaedl jschaedl force-pushed the notifier-add-test-add-transport-factory-to-framework-extension branch 3 times, most recently from 70e1b6e to ddf61c2 Compare April 17, 2021 16:51
@nicolas-grekas nicolas-grekas added this to the 5.x milestone Apr 17, 2021
@nicolas-grekas
Copy link
Member

Can you please merge this with #40844?

@OskarStark
Copy link
Contributor

OskarStark commented Apr 17, 2021 •
edited
Loading

Oh sorry @nicolas-grekas I already merged #40844 😢

@jschaedl can you please rebase? Thanks

@jschaedl jschaedl force-pushed the notifier-add-test-add-transport-factory-to-framework-extension branch from ddf61c2 to 1ba324c Compare April 17, 2021 18:26
@carsonbot carsonbot changed the title [FrameworkBundle] Notifier add test for adding transport factories to framework extension [Notifier] Notifier add test for adding transport factories to framework extension Apr 17, 2021
@OskarStark
Copy link
Contributor

Can you please check Travis?

@jschaedl jschaedl force-pushed the notifier-add-test-add-transport-factory-to-framework-extension branch 2 times, most recently from 93b1522 to 8b6bbfd Compare April 17, 2021 21:10
jschaedl
jschaedl commented Apr 17, 2021
View reviewed changes
jschaedl
jschaedl commented Apr 17, 2021
View reviewed changes
@fabpot fabpot force-pushed the notifier-add-test-add-transport-factory-to-framework-extension branch from 1e24de5 to 3118c90 Compare April 18, 2021 05:55
@fabpot
Copy link
Member

fabpot commented Apr 18, 2021

Thank you @jschaedl.

@fabpot fabpot merged commit f67d11c into symfony:5.x Apr 18, 2021
@jschaedl jschaedl mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jschaedl @nicolas-grekas @OskarStark @fabpot @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy