-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Serializer] Change >=1.7.0 version constraint to >=1.8.0 for package… #49855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… phpdocumentor/type-resolver, as it now has a stable 1.7.* release.
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Hey! Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.2 for bug fixes". Cheers! Carsonbot |
There is no reason to forbid 1.8+. As they follow semver, a 1.8 version is fine to be used as well once available (whether 1.7.x stable releases or 1.8.x-dev is used depends on the minimum-stability you configure). So -1 from me. |
…tor/type-resolver, to any version from 1.4.0 to less than 2.0.0 version to be installed.
Going to re do this from scratch, removing the upper restriction all together. |
6.2 branch Has it correct, but 6.2.7 (down to 6.2.5?) have the limitation --- not sure how I can fix that, since it would look like no change happened against 6.2. So is serializer 6.2.0 newer than 6.2.7? |
No. It is just that the 6.2 branch contains the change done in #49727, which will be part of the 6.2.8 release. |
… phpdocumentor/type-resolver, as it now has a stable 1.7.* release.
Change >=1.7.0 version constraint to >=1.8.0 for package phpdocumentor/type-resolver, as it now has a stable 1.7.* release. If you don't restrict it 1.7.*, it will try to install the develop branch instead.
Additionally (see https://symfony.com/releases):
(lowest branches are regularly merged to upper ones so they get the fixes too).
-->