Skip to content

[Serializer] Change >=1.7.0 version constraint to >=1.8.0 for package… #49855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Serializer] Change >=1.7.0 version constraint to >=1.8.0 for package… #49855

wants to merge 6 commits into from

Conversation

ellisgl
Copy link

@ellisgl ellisgl commented Mar 29, 2023

… phpdocumentor/type-resolver, as it now has a stable 1.7.* release.

Q A
Branch? 6.2 for bug fixes
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

Change >=1.7.0 version constraint to >=1.8.0 for package phpdocumentor/type-resolver, as it now has a stable 1.7.* release. If you don't restrict it 1.7.*, it will try to install the develop branch instead.

Additionally (see https://symfony.com/releases):

… phpdocumentor/type-resolver, as it now has a stable 1.7.* release.
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@stof
Copy link
Member

stof commented Mar 29, 2023

There is no reason to forbid 1.8+. As they follow semver, a 1.8 version is fine to be used as well once available (whether 1.7.x stable releases or 1.8.x-dev is used depends on the minimum-stability you configure).

So -1 from me.

ellisgl added 2 commits March 29, 2023 06:02
…tor/type-resolver, to any version from 1.4.0 to less than 2.0.0 version to be installed.
@ellisgl ellisgl closed this Mar 29, 2023
@ellisgl
Copy link
Author

ellisgl commented Mar 29, 2023

Going to re do this from scratch, removing the upper restriction all together.

@ellisgl ellisgl deleted the serializer-composer branch March 29, 2023 11:23
@ellisgl
Copy link
Author

ellisgl commented Mar 29, 2023

6.2 branch Has it correct, but 6.2.7 (down to 6.2.5?) have the limitation --- not sure how I can fix that, since it would look like no change happened against 6.2. So is serializer 6.2.0 newer than 6.2.7?

@stof
Copy link
Member

stof commented Mar 29, 2023

No. It is just that the 6.2 branch contains the change done in #49727, which will be part of the 6.2.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy