Skip to content

[Security] Fixed the Hebrew translation in the security.he file #59585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

Gil-Had
Copy link
Contributor

@Gil-Had Gil-Had commented Jan 22, 2025

Fixed mistakes in proper Hebrew writing in the previous translation, and confirmed the rest to be correct and in the same style.

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #51898
License MIT

What does this PR do?

Fixes mistakes in proper Hebrew writing in the documentation. The changes include:

  • Correction of typos and grammatical errors.
  • Improved sentence structure for clarity.
  • Consistent terminology usage.

Why is this needed?

These changes improve the readability and professionalism of the documentation for Hebrew-speaking users.

Notes

  • All changes are non-functional and limited to text corrections.
  • Changes are applied to the 6.4 branch as this is the relevant maintained branch.

…nd confirmed the rest to be correct and in the same style.
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have confirmed with ChatGPT that your changes improve the translation.

@@ -4,23 +4,23 @@
<body>
<trans-unit id="1">
<source>An authentication exception occurred.</source>
<target>שגיאה באימות</target>
<target>התרחשה שגיאה באימות.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by ChatGPT:

The second option fully reflects the original by including the verb "occurred," making it more accurate and complete.

</trans-unit>
<trans-unit id="2">
<source>Authentication credentials could not be found.</source>
<target>פרטי זיהוי לא נמצאו.</target>
<target>פרטי הזיהוי לא נמצאו.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by ChatGPT:

The second option is more precise because "פרטי הזיהוי" (with "the") matches the definite "Authentication credentials" in the source.

</trans-unit>
<trans-unit id="3">
<source>Authentication request could not be processed due to a system problem.</source>
<target>לא ניתן היה לעבד את בקשת אימות בגלל בעיית מערכת.</target>
<target>לא ניתן היה לעבד את בקשת האימות בגלל בעיית מערכת.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by ChatGPT:

The second option includes "האימות" (the authentication), which accurately reflects the definite "Authentication request" in the source.

</trans-unit>
<trans-unit id="4">
<source>Invalid credentials.</source>
<target>שם משתמש או סיסמא שגויים.</target>
</trans-unit>
<trans-unit id="5">
<source>Cookie has already been used by someone else.</source>
<target>עוגיה כבר שומשה.</target>
<target>עוגיה כבר שומשה על ידי מישהו אחר.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by ChatGPT:

The second option fully reflects the source by including "על ידי מישהו אחר" (by someone else), ensuring accuracy and completeness.

@@ -32,15 +32,15 @@
</trans-unit>
<trans-unit id="9">
<source>No authentication provider found to support the authentication token.</source>
<target>לא נמצא ספק אימות המתאימה לבקשה.</target>
<target>לא נמצא ספק אימות המתאים לבקשה.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by ChatGPT:

The second option uses "המתאים" (masculine) to correctly match the gender of "ספק" (provider), ensuring grammatical agreement.

</trans-unit>
<trans-unit id="10">
<source>No session available, it either timed out or cookies are not enabled.</source>
<target>אין סיישן זמין, או שתם הזמן הקצוב או העוגיות אינן מופעלות.</target>
<target>אין מפגש זמין, תם הזמן הקצוב או שהעוגיות אינן מופעלות.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by ChatGPT:

The second option uses "מפגש" (session), which is a proper Hebrew term, instead of "סיישן," which is an unnecessary transliteration.

</trans-unit>
<trans-unit id="11">
<source>No token could be found.</source>
<target>הטוקן לא נמצא.</target>
<target>אסימון לא נמצא.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by ChatGPT:

The second option uses "אסימון," the proper Hebrew term for "token," instead of "טוקן," which is an unnecessary transliteration.

@@ -72,11 +72,11 @@
</trans-unit>
<trans-unit id="19">
<source>Too many failed login attempts, please try again in %minutes% minute.</source>
<target>יותר מדי ניסיונות כניסה כושלים, אנא נסה שוב בוד %minutes% דקה.</target>
<target>יותר מדי ניסיונות כניסה כושלים, אנא נסה שוב בעוד %minutes% דקה.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by ChatGPT:

The second option uses "בעוד," which is the correct way to express a future time frame, whereas "בוד" is a typo.

</trans-unit>
<trans-unit id="20">
<source>Too many failed login attempts, please try again in %minutes% minutes.</source>
<target state="needs-review-translation">יותר מדי ניסיונות כניסה כושלים, אנא נסה שוב בעוד %minutes% דקות.</target>
<target>יותר מדי ניסיונות כניסה כושלים, אנא נסה שוב בעוד %minutes% דקות.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by ChatGPT:

Both targets are identical, and the translation is correct as it properly uses "בעוד" (in) and "דקות" (minutes) in the plural form, accurately reflecting the source sentence.

@carsonbot carsonbot changed the title Fixed the Hebrew translation in the security.he file [Translation] Fixed the Hebrew translation in the security.he file Jan 22, 2025
@carsonbot carsonbot changed the title [Translation] Fixed the Hebrew translation in the security.he file [Security] Fixed the Hebrew translation in the security.he file Jan 22, 2025
@fabpot
Copy link
Member

fabpot commented Jan 25, 2025

Thank you @Gil-Had.

@fabpot fabpot merged commit 918c7c7 into symfony:6.4 Jan 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy