[Validator] Fixed problematic translations and improved Hebrew phrasing in Symfony validator messages #59589
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
There was a problem hiding this comment.
Thanks for contributing the translation.
I used ChatGPT to help me in the review.
- I think that the technical terms “MIME type”, “IBAN”, “ISBN-10” should be kept.
- There's also a difference between "תקף" and "חוקי" that seems necessary to discuss.
@Gil-Had you've just proposed an other PR #59585 for Hebrew, would you like to review this PR?
| @@ -4,7 +4,7 @@ | |||
| <body> | |||
| <trans-unit id="1"> | |||
| <source>This value should be false.</source> | |||
| <target>הערך צריך להיות שקר.</target> | |||
| <target>הערך צריך להיות שגוי.</target> | |||
There was a problem hiding this comment.
Approved by ChatGPT:
The second option uses "שגוי" (incorrect), which is the appropriate term in Hebrew for "false" in this context, whereas "שקר" (lie) is misleading and less suitable.
| @@ -16,7 +16,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="4"> | |||
| <source>This value should be blank.</source> | |||
| <target>הערך צריך להיות ריק.</target> | |||
| <target>הערך צריך להיות ריק</target> | |||
There was a problem hiding this comment.
Approved by ChatGPT:
The second option avoids overusing "MIME," translating it into "סוג הקובץ," which is more natural and clear in Hebrew, while maintaining accuracy.
| @@ -68,7 +68,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="17"> | |||
| <source>The mime type of the file is invalid ({{ type }}). Allowed mime types are {{ types }}.</source> | |||
| <target>סוג MIME של הקובץ אינו חוקי ({{ type }}). מותרים סוגי MIME {{ types }}.</target> | |||
| <target>סוג הקובץ אינו חוקי ({{ type }}). הסוגים המותרים הם {{ types }}.</target> | |||
There was a problem hiding this comment.
If the term "MIME" is too technical for this message, it should be removed from the English version also. Otherwise I think it's better keeping the "MIME" term.
The second option uses "סוג הקובץ" (file type), which is more commonly understood in Hebrew than the technical "MIME," making the message clearer while staying accurate.
| @@ -136,7 +136,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="37" resname="This is not a valid IP address."> | |||
| <source>This value is not a valid IP address.</source> | |||
| <target state="needs-review-translation">ערך זה אינו כתובת IP תקפה.</target> | |||
| <target>ערך זה אינו כתובת איי-פי תקינה.</target> | |||
There was a problem hiding this comment.
ChatGPT tell the previous version was better:
The first option uses "כתובת IP תקפה," which is more precise and formal in Hebrew, whereas "איי-פי" in the second option is a transliteration and less professional.
| @@ -192,7 +192,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="51" resname="No temporary folder was configured in php.ini."> | |||
| <source>No temporary folder was configured in php.ini, or the configured folder does not exist.</source> | |||
| <target state="needs-review-translation">לא הוגדרה תיקייה זמנית ב-php.ini, או שהתיקייה המוגדרת אינה קיימת.</target> | |||
| <target>לא הוגדרה תיקייה זמנית בקובץ php.ini, או שהתיקייה שהוגדרה אינה קיימת.</target> | |||
There was a problem hiding this comment.
Approved by ChatGPT:
The second option explicitly states "בקובץ php.ini" (in the file php.ini), which provides greater clarity and aligns with common phrasing in Hebrew technical contexts.
| </trans-unit> | ||
| <trans-unit id="116"> | ||
| <source>This value does not represent a valid week in the ISO 8601 format.</source> | ||
| <target state="needs-review-translation">ערך זה אינו מייצג שבוע תקף בפורמט ISO 8601.</target> | ||
| <target>ערך זה אינו מייצג שבוע חוקי בפורמט ISO 8601.</target> |
There was a problem hiding this comment.
ChatGPT says the previous version was better:
The first option uses "תקף" (valid), which is the accurate translation for "valid" in this context, whereas "חוקי" (legal) in the second option is less appropriate for describing a valid week in the ISO 8601 format.
| </trans-unit> | ||
| <trans-unit id="117"> | ||
| <source>This value is not a valid week.</source> | ||
| <target state="needs-review-translation">ערך זה אינו שבוע חוקי.</target> | ||
| <target>ערך זה אינו שבוע חוקי.</target> |
There was a problem hiding this comment.
ChatGPT suggests an improvement:
The sentence "שבוע חוקי" (legal week) is not the ideal translation for "valid week" in this context. A better option would be "שבוע תקף" (valid week), as "תקף" is the appropriate term for "valid" in technical contexts.
| </trans-unit> | ||
| <trans-unit id="118"> | ||
| <source>This value should not be before week "{{ min }}".</source> | ||
| <target state="needs-review-translation">ערך זה לא אמור להיות לפני שבוע "{{ min }}".</target> | ||
| <target>ערך זה לא אמור להיות מוקדם יותר משבוע "{{ min }}".</target> |
There was a problem hiding this comment.
Approved by ChatGPT:
The second option, "מוקדם יותר משבוע" (earlier than week), provides a clearer and more accurate translation of the concept "before week" in this context. The first option, while understandable, is less natural in Hebrew.
| </trans-unit> | ||
| <trans-unit id="119"> | ||
| <source>This value should not be after week "{{ max }}".</source> | ||
| <target state="needs-review-translation">ערך זה לא אמור להיות לאחר שבוע "{{ max }}".</target> | ||
| <target>ערך זה לא אמור להיות מאוחר יותר משבוע "{{ max }}".</target> |
There was a problem hiding this comment.
Approved by ChatGPT:
The second option, "מאוחר יותר משבוע" (later than week), is a more natural and accurate translation of "after week" in this context, making it sound clearer in Hebrew. The first option, "לא אמור להיות לאחר," while correct, is less idiomatic in this case.
| </trans-unit> | ||
| <trans-unit id="120"> | ||
| <source>This value is not a valid slug.</source> | ||
| <target state="needs-review-translation">ערך זה אינו slug חוקי.</target> | ||
| <target>ערך זה אינו מזהה ייחודי תקין.</target> |
There was a problem hiding this comment.
Approved by ChatGPT:
The second option, "מזהה ייחודי תקין" (valid unique identifier), is a clearer translation, especially since "slug" refers to a URL-friendly identifier. The first option uses "slug" in English, which might not be understood by all Hebrew readers. It's better to provide a more descriptive translation.
Fixed problematic translations and added improved Hebrew phrasing
Q | A -- | -- Branch? | 6.4 Bug fix? | yes New feature? | no Deprecations? | no Issues | None License | MITWhat does this PR do?
This Pull Request fixes problematic translations and improves Hebrew phrasing in Symfony validator messages. The changes include:
Why is this needed?
These changes ensure the translations are clear, professional, and user-friendly for Hebrew-speaking users.
Notes: