Skip to content

[DependencyInjection][FrameworkBundle] Use php-serialize to dump the container for debug/lint commands #60597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

[DependencyInjection][FrameworkBundle] Use php-serialize to dump the container for debug/lint commands #60597

merged 1 commit into from
Jun 26, 2025
+183 −27

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 30, 2025 •
edited
Loading

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

To unlock #60568 this uses serialize() to dump the container, next to the XML dump.

@carsonbot carsonbot added this to the 7.4 milestone May 30, 2025
@nicolas-grekas nicolas-grekas changed the title [DependencyInjection][FrameworkBundle] Use php-serialize to dump the … [DependencyInjection][FrameworkBundle] Use php-serialize to dump the container for debug/link commands May 30, 2025
@nicolas-grekas nicolas-grekas mentioned this pull request May 30, 2025
Open
@symfony symfony deleted a comment from carsonbot May 30, 2025
@nicolas-grekas nicolas-grekas force-pushed the dump-container-ser branch 4 times, most recently from 965f23d to 013e6ce Compare May 30, 2025 14:27
@nicolas-grekas nicolas-grekas force-pushed the dump-container-ser branch 2 times, most recently from e804022 to 930c4a6 Compare June 2, 2025 08:15
@nicolas-grekas nicolas-grekas changed the title [DependencyInjection][FrameworkBundle] Use php-serialize to dump the container for debug/link commands [DependencyInjection][FrameworkBundle] Use php-serialize to dump the container for debug/lint commands Jun 2, 2025
@nicolas-grekas
Copy link
Member Author

Let's merge this @symfony/mergers ?

@nicolas-grekas nicolas-grekas merged commit 7e089a5 into symfony:7.4 Jun 26, 2025
10 of 11 checks passed
@nicolas-grekas nicolas-grekas mentioned this pull request Jun 26, 2025
Closed
@nicolas-grekas nicolas-grekas deleted the dump-container-ser branch June 27, 2025 06:09
@MatTheCat
Copy link
Contributor

@nicolas-grekas the XML dump has an issue because percent signs are not necessarily escaped and env var placeholders are reset to their %env(…)% format, which means e.g. %%env(FOO)%% and %env(FOO)% would both end up as %env(FOO)%.

Could the new dump format be the occasion to fix this issue?

@nicolas-grekas
Copy link
Member Author

Can you double-check this aspect?

@MatTheCat
Copy link
Contributor

Yes, this is what #34541 tried to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN left review comments

@stof stof stof left review comments

@chalasr chalasr chalasr left review comments

@yceruto yceruto yceruto approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

Assignees
No one assigned
Labels
DependencyInjection FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
8 participants
@nicolas-grekas @MatTheCat @GromNaN @stof @yceruto @alexandre-daubois @chalasr @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy