[DependencyInjection][FrameworkBundle] Use php-serialize to dump the container for debug/lint commands #60597
+183
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
965f23d to
013e6ce
Compare
chalasr
reviewed
May 30, 2025
GromNaN
reviewed
May 30, 2025
e804022 to
930c4a6
Compare
nicolas-grekas
commented
Jun 2, 2025
930c4a6 to
f22faac
Compare
f22faac to
fca2a84
Compare
…container for debug/lint commands
fca2a84 to
c128f55
Compare
|
Let's merge this @symfony/mergers ? |
alexandre-daubois
approved these changes
Jun 26, 2025
yceruto
approved these changes
Jun 26, 2025
|
@nicolas-grekas the XML dump has an issue because percent signs are not necessarily escaped and env var placeholders are reset to their Could the new dump format be the occasion to fix this issue? |
|
Can you double-check this aspect? |
|
Yes, this is what #34541 tried to solve. |
|
Opened #61306 |
fabpot
added a commit
that referenced
this pull request
Aug 2, 2025
…inerBuilders (MatTheCat) This PR was merged into the 7.4 branch. Discussion ---------- [FrameworkBundle] Escape parameters when serializing ContainerBuilders | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT Since the `XmlDumper` didn’t escape uncompiled containers’ parameters, there was no way to differentiate a parameter placeholder from its escaped counterpart (e.g. `%%foo%%` and `%foo%` both are dumped as `%foo%`). This could make `lint:container --resolve-env-vars` fail in some cases. This PR doesn’t change the `XmlDumper` to keep BC, but alter the way `ContainerBuilder`s are serialized by #60597 as it didn’t get released yet. Commits ------- 8ad916f [FrameworkBundle] Escape parameters when serializing a ContainerBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unlock #60568 this uses
serialize()to dump the container, next to the XML dump.