Skip to content

[PhpUnitBridge] skip interactive questions asked by Composer #60616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 1, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

following #60587 so that the installation script is not blocked by Composer asking to install the bridge as a dev dependency:

The package you required is recommended to be placed in require-dev (because it is tagged as "testing") but you did not use --dev.
Do you want to re-run the command with --dev? [yes]?

following symfony#60587 so that the installation script is not blocked by
Composer asking to install the bridge as a dev dependency:

```
The package you required is recommended to be placed in require-dev (because it is tagged as "testing") but you did not use --dev.
Do you want to re-run the command with --dev? [yes]?
```
@carsonbot carsonbot added this to the 6.4 milestone Jun 1, 2025
@xabbuh xabbuh changed the title skip interactive questions asked by Composer [PhpUnitBridge] skip interactive questions asked by Composer Jun 1, 2025
@carsonbot carsonbot changed the title [PhpUnitBridge] skip interactive questions asked by Composer skip interactive questions asked by Composer Jun 1, 2025
@carsonbot carsonbot changed the title skip interactive questions asked by Composer [PhpUnitBridge] skip interactive questions asked by Composer Jun 2, 2025
@nicolas-grekas
Copy link
Member

Why no set --dev instead?

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 9f3c279 into symfony:6.4 Jun 2, 2025
17 of 18 checks passed
@nicolas-grekas
Copy link
Member

Good, the questions are not displayed anyway :)

@xabbuh
Copy link
Member Author

xabbuh commented Jun 2, 2025

Why no set --dev instead?

I tried that first but ended of with autoloading issues when running Symfony tests locally and then stopped debugging. 😄

Good, the questions are not displayed anyway :)

In fact they were displayed locally running Symfony's tests. Looks like the behaviour is different in a CI when Composer detects that it runs in a non-interactive environment. 🤷

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 2, 2025

maybe we should set COMPOSER_NO_INTERACTION=1 during the call instead?

@xabbuh xabbuh deleted the pr-60587 branch June 2, 2025 06:58
@xabbuh
Copy link
Member Author

xabbuh commented Jun 2, 2025

Could be worth to investigate it as a future-proof solution in $passthruOrFail indeed.

@xabbuh
Copy link
Member Author

xabbuh commented Jun 3, 2025

see #60675

nicolas-grekas added a commit that referenced this pull request Jun 4, 2025
…-interactively (xabbuh)

This PR was merged into the 6.4 branch.

Discussion
----------

[PhpUnitBridge] implicitly run all Composer commands non-interactively

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #60616 (comment)
| License       | MIT

Commits
-------

2f1408f implicitly run all Composer commands non-interactively
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy