-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PhpUnitBridge] skip interactive questions asked by Composer #60616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
following symfony#60587 so that the installation script is not blocked by Composer asking to install the bridge as a dev dependency: ``` The package you required is recommended to be placed in require-dev (because it is tagged as "testing") but you did not use --dev. Do you want to re-run the command with --dev? [yes]? ```
Why no set --dev instead? |
Thank you @xabbuh. |
Good, the questions are not displayed anyway :) |
I tried that first but ended of with autoloading issues when running Symfony tests locally and then stopped debugging. 😄
In fact they were displayed locally running Symfony's tests. Looks like the behaviour is different in a CI when Composer detects that it runs in a non-interactive environment. 🤷 |
maybe we should set COMPOSER_NO_INTERACTION=1 during the call instead? |
Could be worth to investigate it as a future-proof solution in |
see #60675 |
…-interactively (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [PhpUnitBridge] implicitly run all Composer commands non-interactively | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #60616 (comment) | License | MIT Commits ------- 2f1408f implicitly run all Composer commands non-interactively
following #60587 so that the installation script is not blocked by Composer asking to install the bridge as a dev dependency: