[ObjectMapper] add missing legacy group #61192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 22, 2025
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
| @@ -371,6 +371,9 @@ public static function objectMapperProvider(): iterable | |||
| yield [new ObjectMapper(new ReflectionObjectMapperMetadataFactory(), PropertyAccess::createPropertyAccessor())]; | |||
| } | |||
|
|
|||
| /** | |||
| * @group legacy | |||
| */ | |||
| public function testMapInitializesLazyObject() | |||
There was a problem hiding this comment.
Sould this be renamed to testMapInitializesLazyObjectPriorToPhp84, then rename the one below to testMapInitializesLazyObject? This way in 8.0, we just have to remove the first test case and the second is untouched apart from the annotation
There was a problem hiding this comment.
We could that. But that should happen on 7.3 probably where #61146 has been merged.
There was a problem hiding this comment.
Ah yes indeed, never mind then
There was a problem hiding this comment.
oops, I should have submitted this PR to 7.3 actually 🙈 (cherry-picked in ee67997)
xabbuh
added a commit
that referenced
this pull request
Jul 22, 2025
This PR was merged into the 7.4 branch. Discussion ---------- [ObjectMapper] add missing legacy group | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- f1940f9 add missing legacy group
nicolas-grekas
added a commit
that referenced
this pull request
Jul 22, 2025
…as-grekas) This PR was merged into the 7.3 branch. Discussion ---------- [ObjectMapper] Fix test using LazyObjectInterface | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Instead of #61191 and #61192 Commits ------- 168b3a3 [ObjectMapper] Fix test using LazyObjectInterface
nicolas-grekas
added a commit
that referenced
this pull request
Jul 22, 2025
* 7.4: Simplify UriSigner::verify to use match [ObjectMapper] Fix test using LazyObjectInterface [HttpKernel] Update phpdoc description [Security] Fix added $token argument to UserCheckerInterface::checkPostAuth() minor #61192 [ObjectMapper] add missing legacy group (xabbuh) bugfix(#61139): Only generate an outputDir if none is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.