[FrameworkBundle] Escape parameters when serializing ContainerBuilders #61306
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 2, 2025
fabpot
approved these changes
Aug 2, 2025
|
Thank you @MatTheCat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
XmlDumperdidn’t escape uncompiled containers’ parameters, there was no way to differentiate a parameter placeholder from its escaped counterpart (e.g.%%foo%%and%foo%both are dumped as%foo%). This could makelint:container --resolve-env-varsfail in some cases.This PR doesn’t change the
XmlDumperto keep BC, but alter the wayContainerBuilders are serialized by #60597 as it didn’t get released yet.