[Mailer] Add compatibility for Mailtrap's sandbox #61315
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailtrap's sandbox requires the Inbox ID to be passed as part of the URI, which has previously been neglected.
Correct setter function for inbox id within the transport factory test.
Chris53897
reviewed
Aug 4, 2025
Spelling mistake made with changelog for sandbox compatibility.
|
Sorry about that @Chris53897. Mistake resolved with commit. |
| @@ -34,6 +34,7 @@ final class MailtrapApiTransport extends AbstractApiTransport | |||
| { | |||
| private const HOST = 'send.api.mailtrap.io'; | |||
| private const HEADERS_TO_BYPASS = ['from', 'to', 'cc', 'bcc', 'subject', 'content-type', 'sender']; | |||
| protected ?string $inboxId = null; | |||
There was a problem hiding this comment.
Suggested change
| protected ?string $inboxId = null; | |
| private int $inboxId = 0; |
Comment on lines
+53
to
+55
| public function setInboxId(?string $inboxId): static | ||
| { | ||
| $this->inboxId = is_numeric( $inboxId ) ? $inboxId : null; |
There was a problem hiding this comment.
Suggested change
| public function setInboxId(?string $inboxId): static | |
| { | |
| $this->inboxId = is_numeric( $inboxId ) ? $inboxId : null; | |
| /** | |
| * @return $this | |
| */ | |
| public function setInboxId(int $inboxId): static | |
| { | |
| $this->inboxId = $inboxId; |
There was a problem hiding this comment.
As the DSN getOption() func returns a mixed value, should this not be type-casted to int?
src/Symfony/Component/Mailer/Bridge/Mailtrap/Transport/MailtrapApiTransport.php
Outdated
Show resolved
Hide resolved
Swap order of 7.3 and 7.4 within changelog. Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
Cleaner method of forming URI for sandbox. Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
| @@ -29,8 +29,9 @@ public function create(Dsn $dsn): TransportInterface | |||
| if ('mailtrap+api' === $scheme) { | |||
| $host = 'default' === $dsn->getHost() ? null : $dsn->getHost(); | |||
| $port = $dsn->getPort(); | |||
| $inboxId = $dsn->getOption("inboxId"); | |||
There was a problem hiding this comment.
Suggested change
| $inboxId = $dsn->getOption("inboxId"); | |
| $inboxId = $dsn->getOption('inboxId'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailtrap's sandbox requires the Inbox ID to be passed as part of the URI, which has previously been neglected.
Previously #61305 but I messed up when re-basing to 7.4.
Updates with appropriate tests and changelog.