[Mailer] Add compatibility for Mailtrap's sandbox #61315
+234
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailtrap's sandbox requires the Inbox ID to be passed as part of the URI, which has previously been neglected.
Correct setter function for inbox id within the transport factory test.
Chris53897
reviewed
Aug 4, 2025
Spelling mistake made with changelog for sandbox compatibility.
|
Sorry about that @Chris53897. Mistake resolved with commit. |
src/Symfony/Component/Mailer/Bridge/Mailtrap/Transport/MailtrapApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailtrap/Transport/MailtrapApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailtrap/Transport/MailtrapApiTransport.php
Outdated
Show resolved
Hide resolved
Swap order of 7.3 and 7.4 within changelog. Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
Cleaner method of forming URI for sandbox. Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
src/Symfony/Component/Mailer/Bridge/Mailtrap/Transport/MailtrapTransportFactory.php
Outdated
Show resolved
Hide resolved
|
Thanks for working on this @KiloSierraCharlie. There's still some logic needed to change the endpoint host if an |
Suggested changes made as part of PR symfony#61315.
|
Apoligies @kbond & @nicolas-grekas - new commit e767fd6 with all changes submitted to branch. |
kbond
requested changes
Aug 5, 2025
There was a problem hiding this comment.
I wonder: it isn't super clear that when you have an inboxId, the sandbox is used. Could it lead to some confusion as to why the live isn't being used.
Would it make more sense to have separate DSN schemes for the sandbox?
# SANDBOX SMTP
MAILER_DSN=mailtrap+sandbox+smtp://PASSWORD@default
# SANDBOX API
MAILER_DSN=mailtrap+sandbox+api://INBOX_ID:TOKEN@default
src/Symfony/Component/Mailer/Bridge/Mailtrap/Transport/MailtrapApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailtrap/Transport/MailtrapApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailtrap/Tests/Transport/MailtrapApiTransportTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailtrap/Transport/MailtrapApiTransport.php
Outdated
Show resolved
Hide resolved
Add a new DSN for Mailtrap's sandbox to support the use of the sandbox service & differentiate from the live environment.
Change security of HEADERS_TO_BYPASS to support the sandbox transport.
|
@kbond Thanks for the suggestion, I think you're right - adding a seperate DSN makes it clearer as to which Mailtrap environment is being used. I've created a new transport which extends the original. Unit tests for this new DSN added also. |
KiloSierraCharlie
added a commit
to KiloSierraCharlie/symfony-docs
that referenced
this pull request
Aug 5, 2025
Add documentation relating to the Mailtrap sandbox implementation in 7.4 (symfony/symfony#61315).
Changes to match the Symfony code style.
Changes to match the Symfony code style.
Changes to match the Symfony code style.
Changes to match the Symfony code style.
Changes to match the Symfony code style.
|
I'll get there eventually 😢 |
Use separate tests for sandbox and live APIs. Use phpunit attributes as per recent standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailtrap's sandbox requires the Inbox ID to be passed as part of the URI, which has previously been neglected.
Previously #61305 but I messed up when re-basing to 7.4.
Updates with appropriate tests and changelog.