[Security] Added 'host' option to firewall configuration #8880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should add a note in the component changelog as well. |
|
Should that be under a (new) 2.4.0 section? |
|
Can you also add some tests? |
|
Sorry about that, but can you rebase on current master, because tests have been refactored recently? Thanks. |
|
Sorry, I'm not that good at rebasing. Following the steps on the contributing doc page, I ended up with a history rewrite of about 20 past commits. So I created a new PR with the rebased change at #8905 |
|
Thank you for a very useful fix! Thank you one more time! |
fabpot
added a commit
that referenced
this pull request
Sep 5, 2013
This PR was merged into the master branch. Discussion ---------- Added 'host' option to firewall configuration | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7103 | License | MIT | Doc PR | This is a follow-up of #8880. Commits ------- 94d648b Added 'host' option to firewall configuration
|
superthanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not particularly fond of all the
isset()checks, and would rather set default values for thepatternandhostoptions (tonull). However I'm not sure if that would have any other impact.