Added 'host' option to firewall configuration #8905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @fabpot |
fabpot
added a commit
that referenced
this pull request
Sep 5, 2013
This PR was merged into the master branch. Discussion ---------- Added 'host' option to firewall configuration | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7103 | License | MIT | Doc PR | This is a follow-up of #8880. Commits ------- 94d648b Added 'host' option to firewall configuration
| @@ -244,8 +244,10 @@ private function createFirewall(ContainerBuilder $container, $id, $firewall, &$a | |||
| $matcher = null; | |||
| if (isset($firewall['request_matcher'])) { | |||
| $matcher = new Reference($firewall['request_matcher']); | |||
| } elseif (isset($firewall['pattern'])) { | |||
| $matcher = $this->createRequestMatcher($container, $firewall['pattern']); | |||
| } elseif (isset($firewall['pattern']) || isset($firewall['host'])) { | |||
There was a problem hiding this comment.
@fabpot what about renaming pattern to path to be consistent with routing?
There was a problem hiding this comment.
I proposed that some time ago, but that's not going to happen. This is really a pattern, not a path
|
Hello, how could we achieve the same prior to 2.4 ? |
|
@GiGiGan configure your firewall to use a custom request matcher (so that you can configure it with the settings you want) services:
acme_demo.firewall_matcher:
class: Symfony\Component\HttpFoundation\RequestMatcher
arguments: [null, 'admin.example.org']
security:
firewalls:
main:
request_matcher = acme_demo.firewall_matcher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #8880.