Implement test which checks env relationships #507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a good idea 👍 |
tucksaun
reviewed
Sep 9, 2024
envs/local_test.go
Outdated
| func (s *LocalSuite) TestGenericContainer(c *C) { | ||
| ctx := context.Background() | ||
|
|
||
| composeProject := os.Getenv("COMPOSE_PROJECT_NAME") |
There was a problem hiding this comment.
looks to me that it would be more realistic (and easier to debug?) to use their Docker Compose module: https://golang.testcontainers.org/features/docker_compose/
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
In #505 I've talked about testing the docker integration of the symfony cli more sophisticated. I've implement a proposal which includes testcontainers which start specific containers and checks if the symfony cli generates the correct variables.
The downside of this approach is that the developer which runs tests should have a docker host available (either local installed or configured with the env variable
DOCKER_HOST).Also I'm quit unsure if the tests should be refactored. This is due the fact that I haven't a lot of experience in Go, so perhaps someone can look into it and guide me in the right direction, if the tests are ok.
Thanks!