Skip to content

Implement test which checks env relationships #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Implement test which checks env relationships #516

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 10, 2024

Hi there

This PR continues the work from #507. I've made a mistake and closed the PR by accident.

In #505 I've talked about testing the docker integration of the symfony cli more sophisticated. I've implement a proposal which includes testcontainers which start specific containers and checks if the symfony cli generates the correct variables.
The downside of this approach is that the developer which runs tests should have a docker host available (either local installed or configured with the env variable DOCKER_HOST).
Also I'm quit unsure if the tests should be refactored. This is due the fact that I haven't a lot of experience in Go, so perhaps someone can look into it and guide me in the right direction, if the tests are ok.
Thanks!

I've reworked the testcontainers integration by providing docker-compose files for each scenario. It should help maintaining and debugging this test.

Thanks for looking into it. Feedback is very welcome!

@ghost ghost marked this pull request as draft September 10, 2024 08:54
@ghost
Copy link
Author

ghost commented Sep 10, 2024

@tucksaun I've implemented docker-compose module as requested. Sorry for the inconvenience of the 2 PRs.

@ghost ghost closed this by deleting the head repository Nov 29, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy