Skip to content

feat(eslint-plugin): support yield/await expressions #11417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jul 21, 2025

It seems we can actually support yield and await as the type checker will already resolve the yielded/awaited type.

When yielding, it is possible a generator can be typed such that the yield resolves to an Error.

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 21, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6400c3b
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/687e4c875cc27d0007ccdfab
😎 Deploy Preview https://deploy-preview-11417--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jul 21, 2025

View your CI Pipeline Execution ↗ for commit 6400c3b

Command Status Duration Result
nx run-many -t typecheck ❌ Failed 2m 6s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 5s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 8s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-21 14:25:45 UTC

@43081j 43081j marked this pull request as ready for review July 21, 2025 14:19
It seems we can actually support yield and await as the type checker
will already resolve the yielded/awaited type.

When yielding, it is possible a generator can be typed such that the
`yield` resolves to an `Error`.
@43081j 43081j force-pushed the yielded-awaitlings branch from 64fa81c to 6400c3b Compare July 21, 2025 14:19
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (abb7c4d) to head (6400c3b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11417      +/-   ##
==========================================
- Coverage   90.86%   90.86%   -0.01%     
==========================================
  Files         503      503              
  Lines       51041    51035       -6     
  Branches     8416     8413       -3     
==========================================
- Hits        46379    46373       -6     
  Misses       4648     4648              
  Partials       14       14              
Flag Coverage Δ
unittest 90.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/eslint-plugin/src/rules/only-throw-error.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [only-throw-error] support yielded and awaited errors
1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy