-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): support yield/await expressions #11417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR, @43081j! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
View your CI Pipeline Execution ↗ for commit 6400c3b
☁️ Nx Cloud last updated this comment at |
It seems we can actually support yield and await as the type checker will already resolve the yielded/awaited type. When yielding, it is possible a generator can be typed such that the `yield` resolves to an `Error`.
64fa81c
to
6400c3b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11417 +/- ##
==========================================
- Coverage 90.86% 90.86% -0.01%
==========================================
Files 503 503
Lines 51041 51035 -6
Branches 8416 8413 -3
==========================================
- Hits 46379 46373 -6
Misses 4648 4648
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
It seems we can actually support yield and await as the type checker will already resolve the yielded/awaited type.
When yielding, it is possible a generator can be typed such that the
yield
resolves to anError
.PR Checklist