Skip to content

docs(website): increase 'get started' button contrast #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2022
Merged

docs(website): increase 'get started' button contrast #5313

merged 4 commits into from
Jul 27, 2022

Conversation

andrmaz
Copy link
Contributor

@andrmaz andrmaz commented Jul 5, 2022 •
edited
Loading

PR Checklist

Overview

#5211

Light mode

ts-eslint_button-primary-light

Dark mode

ts-eslint_button-primary-dark

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @andrmaz!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jul 5, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bc3d568. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jul 5, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit bc3d568
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62e1ca756870e000098de7bc
😎 Deploy Preview https://deploy-preview-5313--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Josh-Cena Josh-Cena mentioned this pull request Jul 6, 2022
Closed
3 tasks
@bradzacher bradzacher changed the title docs(website): [Closes #5211] increase 'get started' button contrast docs(website): increase 'get started' button contrast Jul 6, 2022
Josh-Cena
Josh-Cena reviewed Jul 7, 2022
View reviewed changes
@bradzacher bradzacher added the package: website Issues related to the @typescript-eslint website label Jul 18, 2022
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jul 23, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting on this issue @andrmaz! The gold does help with contrast but I have to admit, I'm partial to sticking with shades of blue. 😄

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jul 23, 2022
@Josh-Cena
Copy link
Member

I started off disliking this. But after staring at it a few times, I have to say it looks quite eye-catching ^^

@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Jul 27, 2022
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) July 27, 2022 23:30
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5bc4d43 into typescript-eslint:main Jul 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
package: website Issues related to the @typescript-eslint website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: first homepage "Get Started" button background has low color contrast
4 participants
@andrmaz @Josh-Cena @JoshuaKGoldberg @bradzacher
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy