chore(website): made the button contrast with outline and shadow #5315
Conversation
|
Thanks for the PR, @Aryan-Bhatt-pro! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hello, please let me know if the PR is satisfying the conditions. If in the case of rejection of the PR please let me know what went wrong so that I can improve on that. |
|
This makes the button much, much less legible than before:
Also someone else is already working on it 😄 #5313 Next time, before submitting the PR, make sure there isn't another one addressing the same thing. |
fix(website): made the button contrast with outline and shadow|
Yeah, sorry @Aryan-Bhatt-pro - #5313 was raise by another contributor yesterday! Closing to deduplicate. |
|
Oh ok.
Sure will take care of that next time :)
Thanks for providing the clarity.
Regards
Aryan Bhatt
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Joshua Chen ***@***.***>
Sent: Wednesday, July 6, 2022 6:33:01 PM
To: typescript-eslint/typescript-eslint ***@***.***>
Cc: IMT2020020 Aryan Bhatt ***@***.***>; Mention ***@***.***>
Subject: Re: [typescript-eslint/typescript-eslint] `fix`(website): made the button contrast with outline and shadow (PR #5315)
This makes the button much, much less legible than before:
[image]<https://user-images.githubusercontent.com/55398995/177556372-f4c1a3b6-1b7c-4e03-96a8-ae0dd47d5d86.png>
Also someone else is already working on it 😄 #5313<#5313> Next time, before submitting the PR, make sure there isn't another one addressing the same thing.
—
Reply to this email directly, view it on GitHub<#5315 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASPH43U22KMY5UTYVEOCD2DVSV7YLANCNFSM52ZUHTPQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
PR Checklist
Overview
Made the button contrast with outline and shadow. Now the user will be able to see the button clearly and will trust that its safe to click it.