Skip to content

fix(types): update variable options #9668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(types): update variable options #9668

wants to merge 1 commit into from

Conversation

oliversalzburg
Copy link
Contributor

Aligns types with https://github.com/DefinitelyTyped/DefinitelyTyped/blob/375da3bcb7512239e65f6e1955f982a20bcc20a9/types/eslint/index.d.ts#L1283

This is the second conflict I'm finding with @types/eslint@9. Maybe I'm on the wrong track, or maybe there's a bigger approach that could solve more. I leave this up to more experienced people 😃

Relates to #9634

Issue template skipped, due to minor and clear change.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @oliversalzburg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 744948c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66a7ea5b0ed3c700088b7901
😎 Deploy Preview https://deploy-preview-9668--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 29, 2024

@oliversalzburg oliversalzburg changed the title fix(types): Update variable options fix(types): update variable options Jul 29, 2024
Aligns types with https://github.com/DefinitelyTyped/DefinitelyTyped/blob/375da3bcb7512239e65f6e1955f982a20bcc20a9/types/eslint/index.d.ts#L1283

This is the second conflict I'm finding with `@types/eslint@9`. Maybe I'm on the wrong track, or maybe there's a bigger approach that could solve more. I leave this up to more experienced people 😃

Relates to #9634
@bradzacher
Copy link
Member

We already have a PR open for this - #9657

@bradzacher bradzacher closed this Jul 29, 2024
@oliversalzburg oliversalzburg deleted the patch-1 branch July 30, 2024 21:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy