fix(eslint-plugin): [member-ordering] get accessor member name & take into account `abstract` and decorator #9775

OlivierZal · 2024-08-10T21:07:26Z

PR Checklist

Addresses an existing open issue: fixes Bug: [@typescript-eslint/member-ordering] no error raised when accessors not sorted by alphabetical order #9765
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

typescript-eslint · 2024-08-10T21:07:29Z

Thanks for the PR, @OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-08-10T21:07:45Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`6fcd519`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66ba2da6ca43af0008c563a7
😎 Deploy Preview	https://deploy-preview-9775--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-08-10T21:08:16Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6fcd519. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

OlivierZal · 2024-08-11T06:52:47Z

Hi @Josh-Cena, @JoshuaKGoldberg, @bradzacher,

How can I solve https://cloud.nx.app/runs/xRpPxqp5jU/task/visitor-keys%3Alint ?

bradzacher · 2024-08-11T07:14:41Z

It's a flake

OlivierZal · 2024-08-11T20:52:51Z

Works for non-abstract accessors:

Works for abstract accessors:

OlivierZal · 2024-08-11T21:36:12Z

Test with non-abstract accessor and abstract accessor:

Test with non-decorated accessor and decorated accessor:

codecov · 2024-08-11T21:49:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (fbe5f2d) to head (6fcd519).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9775      +/-   ##
==========================================
- Coverage   87.92%   87.91%   -0.02%     
==========================================
  Files         402      402              
  Lines       13726    13725       -1     
  Branches     3999     3998       -1     
==========================================
- Hits        12069    12066       -3     
- Misses       1351     1352       +1     
- Partials      306      307       +1

Flag	Coverage Δ
unittest	`87.91% <100.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts	`96.80% <100.00%> (-0.93%)`	⬇️
...plugin/src/rules/no-unnecessary-type-parameters.ts	`94.85% <100.00%> (ø)`
packages/eslint-plugin/src/util/misc.ts	`98.63% <ø> (ø)`

Josh-Cena · 2024-08-11T23:11:35Z

Could you add real test cases in the tests folder too?

OlivierZal · 2024-08-12T08:42:28Z

@Josh-Cena, added tests (and fixed format because this commit broke main).

Now it's ready to merge.

JoshuaKGoldberg

OlivierZal · 2024-08-12T15:37:50Z

Thanks @JoshuaKGoldberg, is there any step I need to perform after approval is granted?

Josh-Cena · 2024-08-12T15:39:32Z

packages/eslint-plugin/src/rules/no-unnecessary-type-parameters.ts

-    if (
-      reference.identifier.parent.type === AST_NODE_TYPES.TSTypeReference
-    ) {
+    if (reference.identifier.parent.type === AST_NODE_TYPES.TSTypeReference) {


Hmmm, why is this changed?

@Josh-Cena, explained there

Josh-Cena

Looks good to me :)

Josh-Cena · 2024-08-12T15:44:00Z

It seems wholly unnecessary to enforce up-to-date branches before merging in most cases, FWIW.

(Nothing to do with this PR in particular)

JoshuaKGoldberg · 2024-08-12T16:08:33Z

any step I need to perform after approval is granted

Nothing on your end! Just being excited in general, I suppose. 😄

Thanks for this! Merged & will be released in our weekly release later today.

OlivierZal changed the title ~~Add getMemberName for accessors~~ fix(rule): [member-ordering] get accessor member name Aug 11, 2024

OlivierZal changed the title ~~fix(rule): [member-ordering] get accessor member name~~ fix(eslint-plugin): [member-ordering] get accessor member name Aug 11, 2024

OlivierZal force-pushed the patch-1 branch from 6c7e160 to 135ebe2 Compare August 11, 2024 05:36

typescript-eslint deleted a comment from github-actions bot Aug 11, 2024

OlivierZal force-pushed the patch-1 branch 2 times, most recently from 90f1067 to 9869078 Compare August 11, 2024 20:36

OlivierZal marked this pull request as ready for review August 11, 2024 20:57

OlivierZal force-pushed the patch-1 branch from 68f215a to 62a8484 Compare August 11, 2024 21:32

OlivierZal changed the title ~~fix(eslint-plugin): [member-ordering] get accessor member name~~ fix(eslint-plugin): [member-ordering] get accessor member name & take into account abstract and decorator Aug 11, 2024

OlivierZal force-pushed the patch-1 branch from 009c94e to 31b1d9d Compare August 12, 2024 08:14

OlivierZal added 4 commits August 12, 2024 10:16

fix: handle accessor names

426f87e

fix: abstract not taken into account for accessors

a1b711a

fix: decorator not taken into account for accessors

1ccff9a

Add tests

f4e36c7

OlivierZal force-pushed the patch-1 branch from 31b1d9d to f4e36c7 Compare August 12, 2024 08:16

fix format

d2f3147

JoshuaKGoldberg approved these changes Aug 12, 2024

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 12, 2024

Josh-Cena reviewed Aug 12, 2024

View reviewed changes

Josh-Cena approved these changes Aug 12, 2024

View reviewed changes

Merge branch 'main' into patch-1

6fcd519

JoshuaKGoldberg merged commit 3d9ae44 into typescript-eslint:main Aug 12, 2024
59 checks passed

OlivierZal deleted the patch-1 branch August 12, 2024 16:09

github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024

Uh oh!

fix(eslint-plugin): [member-ordering] get accessor member name & take into account abstract and decorator #9775

fix(eslint-plugin): [member-ordering] get accessor member name & take into account abstract and decorator #9775

Uh oh!

Conversation

OlivierZal commented Aug 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Aug 10, 2024

Uh oh!

netlify bot commented Aug 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Aug 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

OlivierZal commented Aug 11, 2024

Uh oh!

bradzacher commented Aug 11, 2024

Uh oh!

OlivierZal commented Aug 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OlivierZal commented Aug 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Josh-Cena commented Aug 11, 2024

Uh oh!

OlivierZal commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

OlivierZal commented Aug 12, 2024

Uh oh!

Josh-Cena Aug 12, 2024

Choose a reason for hiding this comment

Uh oh!

OlivierZal Aug 12, 2024

Choose a reason for hiding this comment

Uh oh!

Josh-Cena left a comment

Choose a reason for hiding this comment

Uh oh!

Josh-Cena commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg commented Aug 12, 2024

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

fix(eslint-plugin): [member-ordering] get accessor member name & take into account `abstract` and decorator #9775

fix(eslint-plugin): [member-ordering] get accessor member name & take into account `abstract` and decorator #9775

OlivierZal commented Aug 10, 2024 •

edited

Loading

netlify bot commented Aug 10, 2024 •

edited

Loading

nx-cloud bot commented Aug 10, 2024 •

edited

Loading

OlivierZal commented Aug 11, 2024 •

edited

Loading

OlivierZal commented Aug 11, 2024 •

edited

Loading

codecov bot commented Aug 11, 2024 •

edited

Loading

OlivierZal commented Aug 12, 2024 •

edited

Loading

Josh-Cena commented Aug 12, 2024 •

edited

Loading